Lars Volker has posted comments on this change. Change subject: IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps ......................................................................
Patch Set 1: (1 comment) Thanks for the review. I uploaded PS2. I tested this manually by inserting a DCHECK(false) after the breakpad initialization and started a daemon, which then wrote a minidump. Before the glog patch it would not do so. Do we have a way to trigger code execution of particular functions during tests but strip from production builds? Other than that I wouldn't know how to automatically test this. http://gerrit.cloudera.org:8080/#/c/3286/1//COMMIT_MSG Commit Message: PS1, Line 7: PREVIEW > This is no longer a preview, right? Remove please Done -- To view, visit http://gerrit.cloudera.org:8080/3286 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e6b83af1b4ff1b8c916fe6c9052b88b760e188 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
