Michael Brown has posted comments on this change. Change subject: IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3286/4/tests/custom_cluster/test_breakpad.py File tests/custom_cluster/test_breakpad.py: PS4, Line 209: # Kill the rest of the cluster. : self.kill_cluster(SIGKILL) It would be better not to have cleanup actions in tests. Is this needed before teardown_method() gets called? -- To view, visit http://gerrit.cloudera.org:8080/3286 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e6b83af1b4ff1b8c916fe6c9052b88b760e188 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
