Lars Volker has posted comments on this change. Change subject: IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps ......................................................................
Patch Set 3: (1 comment) Thanks Michael for the review. Please see my reply and PS4. http://gerrit.cloudera.org:8080/#/c/3286/3/tests/custom_cluster/test_breakpad.py File tests/custom_cluster/test_breakpad.py: PS3, Line 195: @pytest.mark.execute_serially : def test_dcheck_writes_minidump(self): : """Check that hitting a DCHECK macro writes a minidump.""" > Will this test pass if Impala is a release build? Yes, it will pass. I wasn't sure, so I checked and the bind() call fails, thus also triggering a minidump write. However it does not really test the DCHECK in this case, so I disabled the test on non-dev builds. -- To view, visit http://gerrit.cloudera.org:8080/3286 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e6b83af1b4ff1b8c916fe6c9052b88b760e188 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
