Tim Armstrong has posted comments on this change. Change subject: IMPALA-2033: Netezza compatibility functions quote_ident ......................................................................
Patch Set 2: (3 comments) Thanks for the quick turnaround, I think there are a few corner cases that I'm not sure about still. The fe need to be rebuild since impala-functions.py generates some Java files. http://gerrit.cloudera.org:8080/#/c/3263/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: PS2, Line 1952: ABC I took another look at these tests. Why do the upper-case strings need to be quoted and the lower-case ones not quoted? I think Netezza converts unquoted lower-case to upper-case: maybe this is the wrong way around? PS2, Line 1963: _test I think this should be quoted. See https://www.ibm.com/support/knowledgecenter/SSZJPZ_11.5.0/com.ibm.swg.im.iis.conn.netezza.use.doc/topics/netezza_identifiers.html : "Regular identifiers must begin with a letter; they cannot begin with a digit, underscore, or dollar sign." http://gerrit.cloudera.org:8080/#/c/3263/2/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: PS2, Line 761: all_lowercase Does the string need to be converted to lowercase/ Maybe there's a step missing here? -- To view, visit http://gerrit.cloudera.org:8080/3263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbac4cd10fe08a6bd4871a03ba3b5f2c20fa8ee1 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Shirish Gajera <[email protected]> Gerrit-Reviewer: Shirish Gajera <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
