Tim Armstrong has posted comments on this change. Change subject: IMPALA-2033: Netezza compatibility functions quote_ident ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3263/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: PS2, Line 1952: ABC > I tried this on PostgreSQL and this is the same output I am getting. http:/ Postgres's quote_ident has to quote identifiers based on postgres's quoting rules though. Netezza has different rules, so I wouldn't expect the output to match postgres. http://gerrit.cloudera.org:8080/#/c/3263/2/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: PS2, Line 761: all_lowercase > I didn't get your question. Can you please elaborate ? I don't why we need I was confused why the variable is called 'all_lowercase' when it may contain uppercase characters. I don't see anything that converts the characters to lowerchase. -- To view, visit http://gerrit.cloudera.org:8080/3263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbac4cd10fe08a6bd4871a03ba3b5f2c20fa8ee1 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Shirish Gajera <[email protected]> Gerrit-Reviewer: Shirish Gajera <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
