Michael Ho has posted comments on this change. Change subject: IMPALA-3223: Removal of non-toolchain builds. ......................................................................
Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/3259/6/CMakeLists.txt File CMakeLists.txt: PS6, Line 17: if ("$ENV{SKIP_TOOLCHAIN_BOOTSTRAP}" STREQUAL "true") : message(STATUS "SKIP_TOOLCHAIN_BOOTSTRAP is true, skipping toolchain bootstrap.") : else() : # Download any missing toolchain dependencies. If this fails, fail the build. : set(BOOTSTRAP_CMD "$ENV{IMPALA_HOME}/bin/bootstrap_toolchain.py") : # Download and unpack the dependencies : message(STATUS "Downloading and extracting dependencies.") : execute_process(COMMAND ${BOOTSTRAP_CMD} RESULT_VARIABLE BOOTSTRAP_RESULT) : if (${BOOTSTRAP_RESULT} EQUAL 0) : message(STATUS "Toolchain bootstrap complete.") : else() : message(FATAL_ERROR "Toolchain bootstrap failed.") : endif() : endif() This block will be moved to buildall.sh in the future. http://gerrit.cloudera.org:8080/#/c/3259/6/bin/impala-config.sh File bin/impala-config.sh: PS6, Line 295: export May not need export here. -- To view, visit http://gerrit.cloudera.org:8080/3259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42b60e99fb9caf1294be7ab242856ca3b9a5ab73 Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
