Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3687: Use type from avro schema during schema reconcilation. ......................................................................
Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/3331/2//COMMIT_MSG Commit Message: PS2, Line 7: avro nit: Avro (capitalization) PS2, Line 7: reconcilation nit:typo PS2, Line 9: string/char/varchar nit:capitalize for consitency. PS2, Line 9: here is no effect that we change the I think the commit message can be reworded to indicate the issue we are trying to fix, i.e, having different column name for string types in Avro schema and hive col defs can raise an error ....So we just pick the name from the Avro schema and retain the type from hive coldef... http://gerrit.cloudera.org:8080/#/c/3331/2/fe/src/main/java/com/cloudera/impala/util/AvroSchemaUtils.java File fe/src/main/java/com/cloudera/impala/util/AvroSchemaUtils.java: PS2, Line 116: : : : Why did you remove this? http://gerrit.cloudera.org:8080/#/c/3331/1/testdata/workloads/functional-query/queries/QueryTest/avro-schema-changes.test File testdata/workloads/functional-query/queries/QueryTest/avro-schema-changes.test: Line 72: CREATE EXTERNAL TABLE alltypesagg_changed_column_name_comment ( > I would rather prefer to do this in Hive. you know how? Why in hive? http://gerrit.cloudera.org:8080/#/c/3331/2/testdata/workloads/functional-query/queries/QueryTest/avro-schema-changes.test File testdata/workloads/functional-query/queries/QueryTest/avro-schema-changes.test: PS2, Line 71: # IMPALA-3687 I think avro-schema-resolution.test is a better place for this. PS2, Line 71: avro nit: Avro -- To view, visit http://gerrit.cloudera.org:8080/3331 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3e43b2885853c2b4f207a45a873c9d7f31379cd Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: Yes
