Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3687: Use type from Avro schema during schema reconciliation. ......................................................................
Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/3331/2/fe/src/main/java/com/cloudera/impala/util/AvroSchemaUtils.java File fe/src/main/java/com/cloudera/impala/util/AvroSchemaUtils.java: PS2, Line 116: : : : > because we do not have any logic for treating timestamp differently? based on my understanding, this comment was put here so that the reader understands that timestamp follows the codepath of a string type which we deal differently. Its better to retain this. (Please confirm with Alex) -- To view, visit http://gerrit.cloudera.org:8080/3331 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3e43b2885853c2b4f207a45a873c9d7f31379cd Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: Yes
