Huaisi Xu has posted comments on this change. Change subject: IMPALA-3687: Use type from Avro schema during schema reconciliation. ......................................................................
Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/3331/4//COMMIT_MSG Commit Message: Line 7: IMPALA-3687: Use type from Avro schema during schema reconciliation. > Always prefer the Avro field name during schema reconciliation. It is unclear to me what "field name" refers to... I think we should explicitly say "from schema definition"..? maybe I missed something so I will use your suggestion.. Line 9: There is no effect that we change the name of a STRING/CHAR/VARCHAR > This blurb is very difficult to follow. It would be good to summarize the n Done. I think "but keep the name and comment from the Avro column." should be "but keep the name and comment from Avro schema definition." http://gerrit.cloudera.org:8080/#/c/3331/2/fe/src/main/java/com/cloudera/impala/util/AvroSchemaUtils.java File fe/src/main/java/com/cloudera/impala/util/AvroSchemaUtils.java: PS2, Line 116: : : : > Bharath is correct that the comment had an original intention. The comment Done http://gerrit.cloudera.org:8080/#/c/3331/4/fe/src/main/java/com/cloudera/impala/util/AvroSchemaUtils.java File fe/src/main/java/com/cloudera/impala/util/AvroSchemaUtils.java: PS4, Line 113: A > grammar; also could be rephrased for clarity, e.g.: Done http://gerrit.cloudera.org:8080/#/c/3331/4/testdata/workloads/functional-query/queries/QueryTest/avro-schema-changes.test File testdata/workloads/functional-query/queries/QueryTest/avro-schema-changes.test: Line 71: # IMPALA-3687. Create a table that has different Avro schema from its column definition > Create a table with mismatched column definitions and Avro schema. Done Line 86: LOCATION '$FILESYSTEM_PREFIX/test-warehouse/alltypesaggmultifilesnopart_avro_snap' > remove this clause - it only adds confusion Done Line 95: {"type": ["float", "null"], "name": "float_col_changed", "doc": "float comment changed"}, > typo: changed since we put this in avro-schema-resolution, I changed this to *_mismatch -- To view, visit http://gerrit.cloudera.org:8080/3331 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3e43b2885853c2b4f207a45a873c9d7f31379cd Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: Yes
