Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-3441, IMPALA-3659: check for malformed Avro data ......................................................................
Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/3072/10/be/src/exec/hdfs-avro-scanner.cc File be/src/exec/hdfs-avro-scanner.cc: Line 641: // define i1 @MaterializeTuple(%"class.impala::HdfsAvroScanner"* %this, There's something wrong with the codegen'd handling of errors. I've manually tested the codegen path with well-formed files and that works (plus existing tests). The test files I created disable codegen in the EE test though, and when I fixed it something goes wrong. So hold off on reviewing this part (or help me find the bug :)). -- To view, visit http://gerrit.cloudera.org:8080/3072 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I801a11c496a128e02c564c2a9c44baa5a97be132 Gerrit-PatchSet: 10 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
