Tim Armstrong has posted comments on this change. Change subject: IMPALA-3441, IMPALA-3659: check for malformed Avro data ......................................................................
Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/3072/10/be/src/exec/hdfs-avro-scanner.cc File be/src/exec/hdfs-avro-scanner.cc: Line 641: // define i1 @MaterializeTuple(%"class.impala::HdfsAvroScanner"* %this, > There's something wrong with the codegen'd handling of errors. I've manuall What happened with the invalid files? Crash or incorrect results? http://gerrit.cloudera.org:8080/#/c/3072/10/be/src/exec/read-write-util.cc File be/src/exec/read-write-util.cc: PS10, Line 60: __restrict__ I don't think the restrict helps with buf_end, since we don't dereference it. Maybe it will help with 'buf'. Line 65: Extra blank line. http://gerrit.cloudera.org:8080/#/c/3072/10/be/src/exec/read-write-util.h File be/src/exec/read-write-util.h: Line 97: ZResult() : error(true) { } Maybe make a static constructor like: static ZResult error_result() so it's more obvious in ReadZlong that it's returning an error. I needed to come and look at this struct definition to double-check what the empty contructor did. http://gerrit.cloudera.org:8080/#/c/3072/10/be/src/exec/scanner-context.inline.h File be/src/exec/scanner-context.inline.h: Line 156: if (r.error) return false; UNLIKELY? -- To view, visit http://gerrit.cloudera.org:8080/3072 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I801a11c496a128e02c564c2a9c44baa5a97be132 Gerrit-PatchSet: 10 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
