Dan Hecht has posted comments on this change. Change subject: IMPALA-3441, IMPALA-3659: check for malformed Avro data ......................................................................
Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/3072/10/be/src/exec/read-write-util.cc File be/src/exec/read-write-util.cc: PS10, Line 41: max_len it's a little strange that the slow path and fast path will give different answers in the case a ZInt is too many bytes. In the slow path, we'll return error, but in the fast path we'll return a (truncated) value as long as the thing was within ZLong bytes. if you end up going with the template mentioned in the header, then you could make FindZLength() handle the ZInt case consistently without perf loss. -- To view, visit http://gerrit.cloudera.org:8080/3072 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I801a11c496a128e02c564c2a9c44baa5a97be132 Gerrit-PatchSet: 10 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
