Tim Armstrong has posted comments on this change. Change subject: IMPALA-3611: track unused Disk IO buffer memory ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/3246/4/be/src/runtime/disk-io-mgr.cc File be/src/runtime/disk-io-mgr.cc: Line 688: I'll remove this extra blank line. http://gerrit.cloudera.org:8080/#/c/3246/4/be/src/runtime/disk-io-mgr.h File be/src/runtime/disk-io-mgr.h: Line 232: bool is_cached() { return scan_range_->cached_buffer_ != NULL; } I added this to make the logic around cached buffers a little more explicit. Line 256: /// Reset the buffer descriptor to an uninitialized state. I added this so that we didn't recycle BufferDescriptors in some indeterminate state. -- To view, visit http://gerrit.cloudera.org:8080/3246 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8777cf76f04d34a46f53d53005412e0f1d63b5b7 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
