Tim Armstrong has uploaded a new patch set (#5). Change subject: IMPALA-3611: track unused Disk IO buffer memory ......................................................................
IMPALA-3611: track unused Disk IO buffer memory Track I/O buffers against separate MemTrackers. This gives us better visibility into memory consumption from the debug webpage and from MemTracker consumption dumps. The immediate motivation was in trying to determine whether idle memory consumption of an impalad was caused by a memory leak. We add two trackers: for buffers cached in DiskIoMgr's free list, and another for clients that don't provide a MemTracker (the only one is BufferedBlockMgr, which will be removed at some point). The previous code "tracked" the buffers against the process-wide tracker, but it was a no-op outside of ASAN builds since the process-wide tracker took its value from TCMalloc. The test code required fixing because it assumed that buffers were always credited against the DiskIoMgr's tracker. This only made sense when the DiskIoMgr's tracker is the root process-wide tracker. Fix backend test logging for disk-io-mgr-test. Testing: Ran exhaustive tests, ran local and cluster stress tests. Change-Id: I8777cf76f04d34a46f53d53005412e0f1d63b5b7 --- M be/src/runtime/disk-io-mgr-scan-range.cc M be/src/runtime/disk-io-mgr-test.cc M be/src/runtime/disk-io-mgr.cc M be/src/runtime/disk-io-mgr.h M be/src/runtime/row-batch.cc 5 files changed, 209 insertions(+), 153 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/46/3246/5 -- To view, visit http://gerrit.cloudera.org:8080/3246 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8777cf76f04d34a46f53d53005412e0f1d63b5b7 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
