Michael Ho has posted comments on this change. Change subject: IMPALA-3611: track unused Disk IO buffer memory ......................................................................
Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/3246/6/be/src/runtime/disk-io-mgr.cc File be/src/runtime/disk-io-mgr.cc: PS6, Line 859: d, we should be able to remove the free lists > It's safe to do that here since we're not holding free_buffers_lock_ at thi Just checking my understanding here since you claimed in an earlier reply that we stopped calling GcIoBuffers() but that doesn't seem to be the case. Anyway, I guess it's fine either way as fundamentally, it's not ideal to do the limit checks here but we won't fix it in this patch. http://gerrit.cloudera.org:8080/#/c/3246/7/be/src/runtime/disk-io-mgr.cc File be/src/runtime/disk-io-mgr.cc: PS7, Line 749: L Isn't long 32-bit according to the standard ? I thought we need LL, no ? -- To view, visit http://gerrit.cloudera.org:8080/3246 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8777cf76f04d34a46f53d53005412e0f1d63b5b7 Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
