Tim Armstrong has posted comments on this change. Change subject: IMPALA-3223: Supports download of CDH components from S3. ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3333/2/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: Line 288: def download_cdh_components(toolchain_root, cdh_components): > Updated the script to not download the package at all if the package direct Thanks, I like the idea of the md5sum as an option, but this is easier to use as a default. http://gerrit.cloudera.org:8080/#/c/3333/4/buildall.sh File buildall.sh: Line 252: $IMPALA_HOME/bin/bootstrap_toolchain.py Don't need to comment on this specifically - we have set -e as part of set -euo pipefail enabled in all of our scripts. -- To view, visit http://gerrit.cloudera.org:8080/3333 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16fa79db0005554cc0a116e74775647ba99f8dda Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
