Jim Apple has posted comments on this change. Change subject: IMPALA-3223: Supports download of CDH components from S3. ......................................................................
Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/3333/4//COMMIT_MSG Commit Message: Line 17: To build the ASF tree, set $DOWNLOAD_CDH_COMPONENTS to true. Can you point to the ASF repo: https://git-wip-us.apache.org/repos/asf?p=incubator-impala.git;a=summary Line 20: Once the integration jenkins job is modified to periodically Can you elaborate here - which job, specifically? What does it do when it modifies the S3 buckets? How does it know they need updating? In the long run, for users who do not want to use CDH components, should they download their own components and put them in thirdparty? http://gerrit.cloudera.org:8080/#/c/3333/4/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: Line 91: def bootstrap(toolchain_root, packages): Can you give this function a docstring? Line 320: $IMPALA_TOOLCHAIN. This docstring looks outdated to me, because of your new changes. -- To view, visit http://gerrit.cloudera.org:8080/3333 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16fa79db0005554cc0a116e74775647ba99f8dda Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
