Michael Ho has posted comments on this change. Change subject: IMPALA-3223: Supports download of CDH components from S3. ......................................................................
Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/3333/4//COMMIT_MSG Commit Message: Line 17: To build the ASF tree, set $DOWNLOAD_CDH_COMPONENTS to true. > Can you point to the ASF repo: https://git-wip-us.apache.org/repos/asf?p=in Done Line 20: Once the integration jenkins job is modified to periodically > Can you elaborate here - which job, specifically? Details of the jenkins job is added. The followings are replies to other questions. They are details of our internal process so I won't add that to the commit message. The existing integration jenkins job will periodically download the latest CDH components and run Impala tests along with these new components. If all tests pass, they will be checked into the thirdparty directory and overwrite the previous version checked in. For the new procedure, the jenkins job will do the same testing as before. The only difference is that it will upload the latest stable version of CDH components to the S3 bucket. The details of which has to be worked out as it involves some atomic renaming. If a user wants to run their own version of CDH components (e.g. ASF version of Hadoop), that's perfectly fine but they may need to update impala-config.sh with the appropriate version string of Hadoop he/she is using. There is no guarantee it will pass all the Impala tests with such configuration as we don't plan to test (and officially support) such configuration. http://gerrit.cloudera.org:8080/#/c/3333/4/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: Line 91: def bootstrap(toolchain_root, packages): > Can you give this function a docstring? Done Line 320: $IMPALA_TOOLCHAIN. > This docstring looks outdated to me, because of your new changes. Done http://gerrit.cloudera.org:8080/#/c/3333/4/buildall.sh File buildall.sh: Line 252: # set -e was done above so any failure will terminate this script. > Don't need to comment on this specifically - we have set -e as part of set Done -- To view, visit http://gerrit.cloudera.org:8080/3333 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16fa79db0005554cc0a116e74775647ba99f8dda Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
