Alex Behm has posted comments on this change. Change subject: IMPALA-3491: Use unique_database fixture in test_shell_commandline.py. ......................................................................
Patch Set 5: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/3301/5/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: Line 38: @pytest.fixture thank you for setting a good example here! Line 54: stmt = "CREATE TABLE if not exists %s (i integer, s string)" % fq_table_name Remove the "IF NOT EXISTS" part because we don't want to silently ignore unexpected error conditions. -- To view, visit http://gerrit.cloudera.org:8080/3301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icdcb04a99c0907fc1ba56baa2497fafb33b0e34e Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Ishaan Joshi <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
