David Knupp has posted comments on this change. Change subject: IMPALA-3491: Use unique_database fixture in test_shell_commandline.py. ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/3301/2//COMMIT_MSG Commit Message: PS2, Line 20: Additonal > Additional Done http://gerrit.cloudera.org:8080/#/c/3301/2/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: PS2, Line 78: """A set of sanity tests for the Impa > OK, will do. (I should probably add him as a reviewer anyway.) Done http://gerrit.cloudera.org:8080/#/c/3301/3/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: PS3, Line 55: > Remove "Unique" here. The table name doesn't claim to be unique. Done PS3, Line 56: @pytest.fixture > This is a copy/paste error. I reused your msg from conftest.py. I'll rework Done -- To view, visit http://gerrit.cloudera.org:8080/3301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icdcb04a99c0907fc1ba56baa2497fafb33b0e34e Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Ishaan Joshi <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
