David Knupp has posted comments on this change. Change subject: IMPALA-3491: Use unique_database fixture in test_shell_commandline.py. ......................................................................
Patch Set 4: (1 comment) Note that I also added an execute_serially marker back to one test that refreshes the catalog, thereby invalidating the metadata. This was causing intermittent errors for other tests when run concurrently. http://gerrit.cloudera.org:8080/#/c/3301/3/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: PS3, Line 56: query_options={'sync_ddl': 1}) > What prefixes? This is a copy/paste error. I reused your msg from conftest.py. I'll rework it. (That said, in retrospect I'm pretty sure this check is unnecessary here. request.node.name is the same thing as request.function.__name__. You are already confirming that the name + checksum is a valid identifier in your fixture. If that's the case, than the name alone must be valid as well.) -- To view, visit http://gerrit.cloudera.org:8080/3301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icdcb04a99c0907fc1ba56baa2497fafb33b0e34e Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Ishaan Joshi <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
