Youwei Wang has posted comments on this change. Change subject: IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2. ......................................................................
Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/#/c/3081/17/be/src/util/bit-util.inline.h File be/src/util/bit-util.inline.h: Line 25: inline void ByteSwapScalarLoop(void* dst, const void* src, int len) { > Where? A number of the "Done" comments are not done yet, from what I can se Hi Jim. Sorry for the late upload - I have downloaded the llvm 3.8 and clang 3.8 from the llvm official site and built it, then I have to rebuild the whole impala to make sure the revised code can work now. I have come across some technique problems here but they are all solved now. This procedure takes some time. And the latest patch has been uploaded. And now I am running some benchmark on the string reverse. The result data will be published as it is ready. Thank you. -- To view, visit http://gerrit.cloudera.org:8080/3081 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I392ed5a8d5683f30f161282c228c1aedd7b648c1 Gerrit-PatchSet: 18 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Youwei Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Youwei Wang <[email protected]> Gerrit-HasComments: Yes
