Jim Apple has posted comments on this change. Change subject: IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2. ......................................................................
Patch Set 21: (5 comments) http://gerrit.cloudera.org:8080/#/c/3081/21/be/src/util/bit-util-test.cc File be/src/util/bit-util-test.cc: Line 120: for (int i = 0; i < buf_size; ++i) { std::iota Line 126: for (int j = 0; j < buf_size; ++j) { This verification code is duplicated. Please refactor it so that it is not. Line 131: } while(false); do { P } while (false) van be simplified to just { P } Line 181: do { This block shares enough code with the one above it that they should be refactored to eliminate that duplication. http://gerrit.cloudera.org:8080/#/c/3081/17/be/src/util/bit-util.inline.h File be/src/util/bit-util.inline.h: Line 156: 11, 12, 13, 14, 15, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15); > Hi Jim. static without constexpr might make it slower than just const. Can you rerun the benchmark and check? -- To view, visit http://gerrit.cloudera.org:8080/3081 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I392ed5a8d5683f30f161282c228c1aedd7b648c1 Gerrit-PatchSet: 21 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Youwei Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Youwei Wang <[email protected]> Gerrit-HasComments: Yes
