Youwei Wang has posted comments on this change. Change subject: IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2. ......................................................................
Patch Set 22: (4 comments) http://gerrit.cloudera.org:8080/#/c/3081/21/be/src/util/bit-util-test.cc File be/src/util/bit-util-test.cc: Line 120: > std::iota Done Line 126: EXPECT_EQ(BitUtil::ByteSwap(static_cast<int16_t>(0x1122)), 0x2211); > This verification code is duplicated. Please refactor it so that it is not. Done Line 131: // Test ByteSwapSSE_Unit() with an input/output buffer, swapping up to 16 bytes. > do { P } while (false) van be simplified to just { P } Done Line 181: int buf_size = 64; > This block shares enough code with the one above it that they should be ref Done -- To view, visit http://gerrit.cloudera.org:8080/3081 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I392ed5a8d5683f30f161282c228c1aedd7b648c1 Gerrit-PatchSet: 22 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Youwei Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Youwei Wang <[email protected]> Gerrit-HasComments: Yes
