Huaisi Xu has posted comments on this change. Change subject: IMPALA-3711: Check privileges when necessary ......................................................................
Patch Set 6: (2 comments) sorry for being slow on this.. :) http://gerrit.cloudera.org:8080/#/c/3371/6/fe/src/main/java/com/cloudera/impala/service/MetadataOp.java File fe/src/main/java/com/cloudera/impala/service/MetadataOp.java: PS6, Line 350: fe.getTableNames( : db.getName(), "*", tablePatternMatcher, user) > I don't think there will be any duplicate code. getTableNames that takes as ok I understand.thx Line 547: MetadataOpParams getDbsMetadataParams = MetadataOpParams.MetadataOpParamsBuilder() > ignoreAllColumns(true) is equivalent to hasColumnPattern(false). Irrespecti I see.. thanks! -- To view, visit http://gerrit.cloudera.org:8080/3371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17d8c5b9fb12483e4b01b819fba48b6849311a14 Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: Yes
