Huaisi Xu has uploaded a new patch set (#10). Change subject: IMPALA-3711: Remove unnecessary privilege checks in getDbsMetadata() ......................................................................
IMPALA-3711: Remove unnecessary privilege checks in getDbsMetadata() Previously all code paths useing getDbsMetadata() suffers unnecessary privilege checks: 1. Impala checked privilege of all databases, tables before applying user provided JDBC pattern filters. 2. Impala passed a null pattern to getDbsMetadata() when user did not provide one. However, null pattern is treated as "%", which matches everything. As a result, even though user wants nothing, we ended up checking everything. This patch changes getDbsMetadata()'s interface such that caller can pass addition information and it knows whether pattern is provided or not. This patch also applies filters before checks any privilege. Change-Id: I17d8c5b9fb12483e4b01b819fba48b6849311a14 --- M fe/src/main/java/com/cloudera/impala/catalog/Catalog.java M fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java M fe/src/main/java/com/cloudera/impala/catalog/Db.java M fe/src/main/java/com/cloudera/impala/service/Frontend.java M fe/src/main/java/com/cloudera/impala/service/JniCatalog.java M fe/src/main/java/com/cloudera/impala/service/JniFrontend.java M fe/src/main/java/com/cloudera/impala/service/MetadataOp.java M fe/src/main/java/com/cloudera/impala/util/PatternMatcher.java M fe/src/test/java/com/cloudera/impala/analysis/AuthorizationTest.java M fe/src/test/java/com/cloudera/impala/testutil/BlockIdGenerator.java M fe/src/test/java/com/cloudera/impala/testutil/ImpaladTestCatalog.java M testdata/workloads/functional-query/queries/QueryTest/show.test 12 files changed, 382 insertions(+), 112 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/71/3371/10 -- To view, visit http://gerrit.cloudera.org:8080/3371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I17d8c5b9fb12483e4b01b819fba48b6849311a14 Gerrit-PatchSet: 10 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]>
