Huaisi Xu has posted comments on this change. Change subject: IMPALA-3711: Check privileges when necessary ......................................................................
Patch Set 8: (2 comments) > (2 comments) > > Thanks Huaisi, it looks much better now. Can you please update all > the comments? I will then do a final review. Sorry I was on PTO yesterday. http://gerrit.cloudera.org:8080/#/c/3371/7/fe/src/main/java/com/cloudera/impala/service/Frontend.java File fe/src/main/java/com/cloudera/impala/service/Frontend.java: PS7, Line 595: * Throw ImpalaException when dbName is null or error calling user.getShortName() in : * hasAccess() : */ : public List<String> getTableNames(String dbName, PatternMatcher tablePatternMatcher, : User user) throws ImpalaException { : if (tablePatternMatcher == null) return Collections.emptyList(); : List<String> tblNames = impaladCatalog_.ge > We are not very consistent with our comments. Maybe remove Javadoc for now Done PS7, Line 605: String tblName = iter.next(); : PrivilegeRequest privilegeRequest = new Privi > You can use this pattern instead here and everywhere else. emptyList() is a Done -- To view, visit http://gerrit.cloudera.org:8080/3371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17d8c5b9fb12483e4b01b819fba48b6849311a14 Gerrit-PatchSet: 8 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: Yes
