David Knupp has posted comments on this change. Change subject: IMPALA-3664: S3A test_keys_do_not_work fails ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/3392/3/tests/custom_cluster/test_s3a_access.py File tests/custom_cluster/test_s3a_access.py: Line 50: @pytest.mark.execute_serially Just checking -- since each test now sets up its own uniquely named database, do these still need to be marked to execute serially? I think that S3 test *suites* run serially by default, but do the individual tests need to as well? Line 63: location '{1}/tinytable'".format(unique_database, WAREHOUSE)) I guess my only question is whether there could be issue with the fact that the unique_database fixture doesn't specify a warehouse when it creates the DB, but you do specify one when you create the table. I presume this works, but I just wanted to ask since I'm still a little unclear on the concept of a warehouse. -- To view, visit http://gerrit.cloudera.org:8080/3392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23b541eef747dd62e59390f8cc9ac6e5742ead40 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-HasComments: Yes
