Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3664: S3A test_keys_do_not_work fails ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3392/3/tests/custom_cluster/test_s3a_access.py File tests/custom_cluster/test_s3a_access.py: Line 57: from the core-site configuration.''' > In that case, should we just remove -s3a_access_key_cmd? My opinion is that we can leave it as it is for now because if a user builds their own custom logic of securing the S3 keys for the HMS (I'm not sure how many would, but still), they wouldn't need to do that for Impala too and could just use this option. Also, this doesn't do any harm by being in the codebase for now. -- To view, visit http://gerrit.cloudera.org:8080/3392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23b541eef747dd62e59390f8cc9ac6e5742ead40 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
