Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-3664: S3A test_keys_do_not_work fails
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3392/3/tests/custom_cluster/test_s3a_access.py
File tests/custom_cluster/test_s3a_access.py:

Line 63:          location '{1}/tinytable'".format(unique_database, WAREHOUSE))
> I guess my only question is whether there could be issue with the fact that
So usually we wouldn't need to use the WAREHOUSE here because the location of 
the table would default to the default location of the database.
However, this is an external table, meaning that it uses existing data from 
another table. So the location I pass is of an already existing table i.e. 
'WAREHOUSE/tinytable' which actually belongs to the 'functional.tinytable' 
table.


-- 
To view, visit http://gerrit.cloudera.org:8080/3392
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23b541eef747dd62e59390f8cc9ac6e5742ead40
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Sailesh Mukil <[email protected]>
Gerrit-Reviewer: David Knupp <[email protected]>
Gerrit-Reviewer: Sailesh Mukil <[email protected]>
Gerrit-HasComments: Yes

Reply via email to