Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3729: batch_size=1 coverage for avro scanner ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/3413/1//COMMIT_MSG Commit Message: PS1, Line 12: nit: is http://gerrit.cloudera.org:8080/#/c/3413/1/bin/load-data.py File bin/load-data.py: PS1, Line 142: inconsistent indentation http://gerrit.cloudera.org:8080/#/c/3413/1/tests/common/test_result_verifier.py File tests/common/test_result_verifier.py: Line 205: actual_set = set(map(str, actual_results.rows)) Is this the right way to verify if it's superset? What if actual = [1, 1, 1] and expected = [1]. Then can we say that expected is a superset? http://gerrit.cloudera.org:8080/#/c/3413/1/tests/util/test_file_parser.py File tests/util/test_file_parser.py: Line 26: return query_section_text.rstrip("\n").rstrip(';') Would it be better to rstrip("\n;")? -- To view, visit http://gerrit.cloudera.org:8080/3413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia007e558d92c7e4ce30be90446fdbb1f50a0ebc4 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
