Tim Armstrong has posted comments on this change. Change subject: IMPALA-3729: batch_size=1 coverage for avro scanner ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/3413/4//COMMIT_MSG Commit Message: PS4, Line 14: of > nit: off Done http://gerrit.cloudera.org:8080/#/c/3413/4/tests/common/test_result_verifier.py File tests/common/test_result_verifier.py: PS4, Line 12: remove_comments, split_section_lines, : join_section_lines > Can you put each of these on a separate line including remove comments. Als Done http://gerrit.cloudera.org:8080/#/c/3413/4/tests/data_errors/test_data_errors.py File tests/data_errors/test_data_errors.py: PS4, Line 18: from tests.common.test_dimensions import create_exec_option_dimension : from tests.common.impala_test_suite import ImpalaTestSuite : from tests.common.skip import SkipIfS3, SkipIfLocal > These should be in alphabetical order. Also the "import x" should be before Done -- To view, visit http://gerrit.cloudera.org:8080/3413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia007e558d92c7e4ce30be90446fdbb1f50a0ebc4 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
