Taras Bobrovytsky has posted comments on this change.

Change subject: IMPALA-3729: batch_size=1 coverage for avro scanner
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3413/2/tests/common/test_result_verifier.py
File tests/common/test_result_verifier.py:

Line 202:     raise Exception("Duplicate rows in expected results: %s" % 
str(expected_results.rows))
> My thought was to prevent mistakes in writing test files. E.g. if someone w
I agree that it will help with catching mistakes, let's keep it.


-- 
To view, visit http://gerrit.cloudera.org:8080/3413
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia007e558d92c7e4ce30be90446fdbb1f50a0ebc4
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Taras Bobrovytsky <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: Yes

Reply via email to