Tim Armstrong has posted comments on this change. Change subject: IMPALA-3729: batch_size=1 coverage for avro scanner ......................................................................
Patch Set 5: Ah sorry, missed that previous comment. My feeling is that, given data corruption, we don't have an exact expected output, just a set of "sane" outputs. The pass criteria should be that we return an error for each corrupt file, plus maybe some valid rows. batch_size is an implementation detail that helps us exercise some additional code paths but shouldn't affect the pass criteria. -- To view, visit http://gerrit.cloudera.org:8080/3413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia007e558d92c7e4ce30be90446fdbb1f50a0ebc4 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
