Alex Behm has uploaded a new patch set (#2). Change subject: IMPALA-3678: Fix migration of predicates into union operands with an order by + limit. ......................................................................
IMPALA-3678: Fix migration of predicates into union operands with an order by + limit. There were two separate issues: First, the SortNode incorrectly picked up unassigned conjuncts, and expected those to be empty. In this case where predicates are migrated into union operands, there could actually be unassigned conjuncts bound by the SortNode's tuple id (and so would be incorrectly picked up). The fix is to not pick up unassigned conjuncts in the SortNode, and allow them to be picked up later (into a SelectNode). Second, when generating the plan for union operands we were missing a call to graft a SelectNode on top of the operand plan to capture unassigned conjuncts. Change-Id: I95d105ac15a3dc975e52dfd418890e13f912dfce --- M fe/src/main/java/com/cloudera/impala/planner/SingleNodePlanner.java M fe/src/main/java/com/cloudera/impala/planner/SortNode.java M testdata/workloads/functional-planner/queries/PlannerTest/union.test 3 files changed, 88 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/00/3600/2 -- To view, visit http://gerrit.cloudera.org:8080/3600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I95d105ac15a3dc975e52dfd418890e13f912dfce Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]>
