Alex Behm has posted comments on this change. Change subject: IMPALA-3678: Fix migration of predicates into union operands with an order by + limit. ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3600/2/fe/src/main/java/com/cloudera/impala/planner/SortNode.java File fe/src/main/java/com/cloudera/impala/planner/SortNode.java: Line 93: // can be placed in a downstream SelectNode. A SortNode cannot evaluate conjuncts. > ...that doesn't involve union. I think this can only happen with a union. This case occurs when we have unassigned predicates bound by a sort node. That means the predicates must come from an enclosing query block. However, we prevent migration of predicates into inline views that have an order by + limit or analytics. So the only case I think this can happen is when migrating predicates into the operands of a union. http://gerrit.cloudera.org:8080/#/c/3600/2/testdata/workloads/functional-planner/queries/PlannerTest/union.test File testdata/workloads/functional-planner/queries/PlannerTest/union.test: Line 2732: # IMPALA-3678: Same as abpve but with union distinct. > above Done -- To view, visit http://gerrit.cloudera.org:8080/3600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95d105ac15a3dc975e52dfd418890e13f912dfce Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
