Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-3678: Fix migration of predicates into union operands 
with an order by + limit.
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3600/2/fe/src/main/java/com/cloudera/impala/planner/SortNode.java
File fe/src/main/java/com/cloudera/impala/planner/SortNode.java:

Line 93:     // can be placed in a downstream SelectNode. A SortNode cannot 
evaluate conjuncts.
> can you create a test for this fix?
...that doesn't involve union.


-- 
To view, visit http://gerrit.cloudera.org:8080/3600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95d105ac15a3dc975e52dfd418890e13f912dfce
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Alex Behm <[email protected]>
Gerrit-Reviewer: Marcel Kornacker <[email protected]>
Gerrit-HasComments: Yes

Reply via email to