Jim Apple has posted comments on this change. Change subject: IMPALA-3817: Ensure filter hash function is the same on all hardware. ......................................................................
Patch Set 1: > This also impacts data-stream-mgr. Is that expected? > Also, does this hash need to match codegen GetHashFunction()? Or > maybe I'm thinking of HashUtil::Hash(). Yes, it is expected. We could split them, but I don't think that the extra code complexity is worth the benefit when there's no measureable performance impact. This does not need to match GetHashFunction. -- To view, visit http://gerrit.cloudera.org:8080/3566 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia09b67f9e987af3e2c8ac12c347b95a7e09ce6fa Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
