Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3566
to look at the new patch set (#2).
Change subject: IMPALA-3817: Ensure filter hash function is the same on all
hardware.
......................................................................
IMPALA-3817: Ensure filter hash function is the same on all hardware.
If some nodes in a cluster support the hardware CRC instruction, then
those nodes would use that hash function when testing filters. This
change uses Murmur2 always. Murmur2 is slower, but a perf run on a
16-node cluster showed negligible performance differences.
This impacts DataStreamMgr's hash function, but that that also doesn't
show a perf difference.
(Also, remove unused hash function from HashUtil that was made dead
code by an earlier commit.)
Change-Id: Ia09b67f9e987af3e2c8ac12c347b95a7e09ce6fa
---
M be/src/runtime/raw-value.inline.h
M be/src/util/hash-util.h
2 files changed, 16 insertions(+), 61 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/66/3566/2
--
To view, visit http://gerrit.cloudera.org:8080/3566
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia09b67f9e987af3e2c8ac12c347b95a7e09ce6fa
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Jim Apple <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Jim Apple <[email protected]>
Gerrit-Reviewer: Mostafa Mokhtar <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
