Jim Apple has posted comments on this change.

Change subject: IMPALA-3817: Ensure filter hash function is the same on all 
hardware.
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3566/1//COMMIT_MSG
Commit Message:

Line 13: 
> please also mention that this impacts DataStreamMgr's hash function, but th
Done


http://gerrit.cloudera.org:8080/#/c/3566/1/be/src/runtime/raw-value.inline.h
File be/src/runtime/raw-value.inline.h:

Line 210: 
> let's add a comment saying the choice of hash function needs to be consiste
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3566
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia09b67f9e987af3e2c8ac12c347b95a7e09ce6fa
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Jim Apple <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Jim Apple <[email protected]>
Gerrit-Reviewer: Mostafa Mokhtar <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: Yes

Reply via email to