Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3210: last/first_value() support for IGNORE NULLS ......................................................................
Patch Set 10: (9 comments) http://gerrit.cloudera.org:8080/#/c/3328/10/fe/src/main/java/com/cloudera/impala/analysis/AnalyticExpr.java File fe/src/main/java/com/cloudera/impala/analysis/AnalyticExpr.java: Line 589: * 4. Reverse the ordering and window, and flip first_value() ans last_value(), if the spelling Line 593: * 5. first_value(): unify description of these cases: start with the condition, then describe the rewrite Line 594: * Set the upper boundary to CURRENT_ROW if the lower boundary is start/end instead of lower/upper Line 730: if (window_ != null make this look more similar to the if stmt for case 3 http://gerrit.cloudera.org:8080/#/c/3328/10/fe/src/test/java/com/cloudera/impala/analysis/AnalyzeExprsTest.java File fe/src/test/java/com/cloudera/impala/analysis/AnalyzeExprsTest.java: Line 719: AnalyzesOk("select first_value(tinyint_col ignore nulls) over (order by id) from " also add last_value and also include the non-ignore variants http://gerrit.cloudera.org:8080/#/c/3328/10/testdata/workloads/functional-planner/queries/PlannerTest/analytic-fns.test File testdata/workloads/functional-planner/queries/PlannerTest/analytic-fns.test: Line 1526: # Set the upper boundary to CURRENT_ROW for first_value() if the lower boundary is upper and lower are ambiguous (i always picture upper to mean end bound). best switch to start and end or something like that. Line 1535: # range between 4 preceding and unbounded following), remove obsolete lines Line 1544: # window, order, and function shoud be revered spelling Line 1567: | window: ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW isn't this the same as 'range between ub preceding and current row'? in that case, normalize to one of them. -- To view, visit http://gerrit.cloudera.org:8080/3328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic27525e2237fb54318549d2674f1610884208e9b Gerrit-PatchSet: 10 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
