Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3210: last/first_value() support for IGNORE NULLS ......................................................................
Patch Set 11: (3 comments) Matt, could you also take another look at the window standardization logic? http://gerrit.cloudera.org:8080/#/c/3328/11/fe/src/main/java/com/cloudera/impala/analysis/AnalyticExpr.java File fe/src/main/java/com/cloudera/impala/analysis/AnalyticExpr.java: Line 593: * Set the end boundary to CURRENT_ROW if the start boundary is the 'if the start boundary ...' is part of the condition; merge into preceding line http://gerrit.cloudera.org:8080/#/c/3328/11/testdata/workloads/functional-planner/queries/PlannerTest/analytic-fns.test File testdata/workloads/functional-planner/queries/PlannerTest/analytic-fns.test: Line 1595: last_value(int_col) over(partition by tinyint_col order by id desc nulls first, bool_col asc nulls last long line Line 1617: 07:ANALYTIC shouldn't this one be coalesced with node 06, given that they now have the same window? -- To view, visit http://gerrit.cloudera.org:8080/3328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic27525e2237fb54318549d2674f1610884208e9b Gerrit-PatchSet: 11 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
