Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3210: last/first_value() support for IGNORE NULLS ......................................................................
Patch Set 13: (5 comments) http://gerrit.cloudera.org:8080/#/c/3328/11/fe/src/main/java/com/cloudera/impala/analysis/AnalyticExpr.java File fe/src/main/java/com/cloudera/impala/analysis/AnalyticExpr.java: PS11, Line 565: a few cases: : * a) Start bound is X FOLLOWING or CURRENT ROW (X=0): : * Use 'last_value' with a window where both bounds are X FOLLOWING (or : * CURRENT ROW). Setting the s > I'd vote to remove this text (which I think was already here before) as the Done PS11, Line 671: daryType.PRE > LAST_VALUE Done PS11, Line 747: wi > nit: extra spaces here? Whatever is consistent with other code in this file Done http://gerrit.cloudera.org:8080/#/c/3328/11/testdata/workloads/functional-planner/queries/PlannerTest/analytic-fns.test File testdata/workloads/functional-planner/queries/PlannerTest/analytic-fns.test: Line 1617: | functions: last_value(bigint_col) > Yes I think we could add this as an optimization for ROWS windows. Thomas, https://issues.cloudera.org/browse/IMPALA-3858 http://gerrit.cloudera.org:8080/#/c/3328/11/testdata/workloads/functional-query/queries/QueryTest/decimal.test File testdata/workloads/functional-query/queries/QueryTest/decimal.test: > new test cases for decimal? Done -- To view, visit http://gerrit.cloudera.org:8080/3328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic27525e2237fb54318549d2674f1610884208e9b Gerrit-PatchSet: 13 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
