Alex Behm has posted comments on this change. Change subject: IMPALA-3845: Split up hdfs-parquet-scanner.cc into more files/components. ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3596/2/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 230: ColumnReader* HdfsParquetScanner::CreateReader( > Nice! Much better, thanks. Done. Actually, nvm. I tried this approach, but it's hard to do because the HdfsParquetScanner has a lot of static_casts to a specific column reader type. What I did is minimize exposure in the .h file which still seems a little cleaner than before. -- To view, visit http://gerrit.cloudera.org:8080/3596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c5fd46f9c1a0ff2a4c30ea5a712fbae17c68f92 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
