Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3845: Split up hdfs-parquet-scanner.cc into more files/components. ......................................................................
Patch Set 4: Code-Review+2 (5 comments) http://gerrit.cloudera.org:8080/#/c/3596/4/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 268: ParquetSchemaResolver schema_resolver(*scan_node_->hdfs_table(), why move this up? http://gerrit.cloudera.org:8080/#/c/3596/3/be/src/exec/parquet-column-readers.h File be/src/exec/parquet-column-readers.h: Line 15: #ifndef IMPALA_PARQUET_COLUMN_READERS_H > I actually need to expose several column readers in this .h because the Hdf yes, now the plural makes sense. http://gerrit.cloudera.org:8080/#/c/3596/4/be/src/exec/parquet-schema-resolver.h File be/src/exec/parquet-schema-resolver.h: Line 1: // Copyright 2016 Cloudera Inc. rename file to parquet-schema-utils? Line 27: /// Checks the version of the given file and returns a non-OK status if move these 3 functions into namespace/class ParquetUtils or something like that? do we already have that somewhere? Line 31: extra blank line -- To view, visit http://gerrit.cloudera.org:8080/3596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c5fd46f9c1a0ff2a4c30ea5a712fbae17c68f92 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
