Alex Behm has posted comments on this change. Change subject: IMPALA-3845: Split up hdfs-parquet-scanner.cc into more files/components. ......................................................................
Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/3596/3/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 2402 > what happened to this? Moved into parquet-schema-resolver.cc Line 1078: HdfsParquetScanner::FileVersion::FileVersion(const string& created_by) { > also move this out? Done Line 1126: Status HdfsParquetScanner::ValidateFileMetadata() { > can all metadata handling be moved to schema-resolver? I moved the major metadata checking functions into schema-resolver. I think we should rename that file to parquet-file-metadata.h or similar, but I didn't do that now so you can better see the differences from the previous patch set. I'll also make the corresponding changes to the commit msg later. http://gerrit.cloudera.org:8080/#/c/3596/3/be/src/exec/parquet-column-readers.h File be/src/exec/parquet-column-readers.h: Line 15: #ifndef IMPALA_PARQUET_COLUMN_READERS_H > why not call this parquet-column-reader.h? I actually need to expose several column readers in this .h because the HdfsParquetScanner has many static_casts to column reader subclasses (the current patch set only worked due to mistakenly including a .cc in the right place, that's now fixed too). So leave the plural? Works for me either way. http://gerrit.cloudera.org:8080/#/c/3596/3/be/src/exec/parquet-schema-resolver.cc File be/src/exec/parquet-schema-resolver.cc: Line 35: string PrintRepetitionType(const parquet::FieldRepetitionType::type& t) { > are these meant to be globally visible? Good point. Made static. -- To view, visit http://gerrit.cloudera.org:8080/3596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c5fd46f9c1a0ff2a4c30ea5a712fbae17c68f92 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
