Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3210: last/first_value() support for IGNORE NULLS ......................................................................
Patch Set 13: Code-Review+1 (2 comments) Thanks! Just add 1 more test case for now. Let's chat tmr/Fri about next steps. http://gerrit.cloudera.org:8080/#/c/3328/13/testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test File testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test: PS13, Line 1105: ---- QUERY : # IMPALA-1559: FIRST_VALUE rewrite function intermediate type not matching slot type : select : first_value(-32.9) over (order by id rows between 92 preceding and unbounded following), : first_value(1.1) over (order by id rows between 92 preceding and 1 preceding) : from alltypestiny : ---- RESULTS: VERIFY_IS_EQUAL_SORTED : -32.9,NULL : -32.9,1.1 : -32.9,1.1 : -32.9,1.1 : -32.9,1.1 : -32.9,1.1 : -32.9,1.1 : -32.9,1.1 : ---- TYPES : DECIMAL, DECIMAL hm I may have been wrong, maybe we just don't run these on avro at all today if this was already in here. http://gerrit.cloudera.org:8080/#/c/3328/13/testdata/workloads/functional-query/queries/QueryTest/decimal.test File testdata/workloads/functional-query/queries/QueryTest/decimal.test: PS13, Line 455: first_value(d1) over (order by d1) no first_value ignore nulls -- To view, visit http://gerrit.cloudera.org:8080/3328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic27525e2237fb54318549d2674f1610884208e9b Gerrit-PatchSet: 13 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
