Michael Brown has posted comments on this change.

Change subject: Enable TPC-H workload for Kudu tables
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3633/5/testdata/datasets/tpch/tpch_schema_template.sql
File testdata/datasets/tpch/tpch_schema_template.sql:

PS5, Line 51:   'kudu.key_columns' = 'l_orderkey, l_partkey, l_suppkey, 
l_linenumber'
> Was there any deep thought on how you chose the primary keys? In some of th
I meant tables, not queries.


-- 
To view, visit http://gerrit.cloudera.org:8080/3633
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a5de71fefa92a78970226d8f49ef445d28f9289
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Dimitris Tsirogiannis <[email protected]>
Gerrit-Reviewer: David Knupp <[email protected]>
Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
Gerrit-Reviewer: Sailesh Mukil <[email protected]>
Gerrit-HasComments: Yes

Reply via email to