Dimitris Tsirogiannis has posted comments on this change. Change subject: Enable TPC-H workload for Kudu tables ......................................................................
Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/3633/5/testdata/datasets/tpch/tpch_schema_template.sql File testdata/datasets/tpch/tpch_schema_template.sql: PS5, Line 46: distribute by hash (l_orderkey, l_partkey, l_suppkey, l_linenumber) into 9 buckets > Please change to Done PS5, Line 51: 'kudu.key_columns' = 'l_orderkey, l_partkey, l_suppkey, l_linenumber' > Please change to We can't do that at moment because the primary key columns must be specified in the beginning of the column definitions of the table. We could reorder them but then we would need to change both the way data are loaded into this table for both kudu and non-kudu formats and the results in some cases. The Kudu team has started working on removing this restriction. When that happens, we can simply change the primary key as you suggested without having to do any other changes. Line 263: 'kudu.key_columns' = 'o_orderkey' > Please change to 'o_orderdate,o_orderkey' Same comment as above. I think it's ok to leave with this for now and change it to what you suggested when Kudu removes the restriction on the primary key column ordering. http://gerrit.cloudera.org:8080/#/c/3633/5/testdata/workloads/tpch/queries/tpch-kudu-q1.test File testdata/workloads/tpch/queries/tpch-kudu-q1.test: Line 8: round(sum(l_extendedprice), 1) as sum_base_price, > Why is the rounding needed? Unfortunately yes. Otherwise we get slightly different results when we run these queries that perform arithmetic operations on doubles, resulting in test failures. We used to have these round() functions in the pre-decimal Impala era. Unfortunately Kudu forces us to reintroduce them. That also answers your question on why we need separate test files for Kudu (queries and results are slightly different). -- To view, visit http://gerrit.cloudera.org:8080/3633 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a5de71fefa92a78970226d8f49ef445d28f9289 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
