Mostafa Mokhtar has posted comments on this change. Change subject: Enable TPC-H workload for Kudu tables ......................................................................
Patch Set 5: (3 comments) Why add tpch-kudu-q*.test? The queries should be identical to the already existing TPC-H queries, correct? http://gerrit.cloudera.org:8080/#/c/3633/5/testdata/datasets/tpch/tpch_schema_template.sql File testdata/datasets/tpch/tpch_schema_template.sql: PS5, Line 46: distribute by hash (l_orderkey, l_partkey, l_suppkey, l_linenumber) into 9 buckets > Kind of ad-hoc. We run the tests in a pseudo-cluster of size 3, so I picked Please change to distribute by hash (l_orderkey) into 9 buckets PS5, Line 51: 'kudu.key_columns' = 'l_orderkey, l_partkey, l_suppkey, l_linenumber' > I used the official TPC-H spec for that. Please change to 'kudu.key_columns' = 'l_shipdate,l_orderkey, l_linenumber' Line 263: 'kudu.key_columns' = 'o_orderkey' Please change to 'o_orderdate,o_orderkey' Will need to change column order for the DDL to work. -- To view, visit http://gerrit.cloudera.org:8080/3633 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a5de71fefa92a78970226d8f49ef445d28f9289 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
